React Hook useMemo has missing dependencies: 'locallyStoredTransactions', 'pageParams.pageNumber', 'pageParams.searchString', and 'type'. Either include them or remove the dependency array.eslintreact-hooks/exhaustive-deps

do we need the other deps?

We haven't had them before but I will have a look.

Maybe @dewanshparashar can have a look as well as I don't believe I've made any changes here before.

In dependencies,

• we don't need locallyStoredTransactions since this state object mutates very frequently and localTransactionsKey (string) is derived from it to keep things under control.
• pageNumber and searchString can be added, but we only need this memo function to run for the very first page so adding these doesn't make a difference to the logic / result. Just that it will recalculate and do an early return for each update. It's optional.

If we go ahead with it, I'd suggest a different PR to isolate it's impact.

we don't need locallyStoredTransactions since this state object mutates very frequently and localTransactionsKey (string) is derived from it to keep things under control.

Then we should either memo it, or not having it as a dependencies, otherwise it make things unpredictable

pageNumber and searchString can be added, but we only need this memo function to run for the very first page so adding these doesn't make a difference to the logic / result. Just that it will recalculate and do an early return for each update. It's optional.

If they are part of the callback of useEffect, then they should be included, even if they never change

Isn't this only used in one place? Let's move it there then

Hm, I don't see why this is necessary, as we should already know if something's an eth withdrawal or a token withdrawal. So we can do the mapping first before we put them all together into a single array and then we don't need this check

We have another instance of sorting by timestamp in this file. So let's extract to a function and also mention that it's descending (if I'm not mistaken):

type Timestamped = { 
  timestamp?: BigNumber
}

function sortByTimestampDescending(a: Timestamped, b: Timestamped) {
  const aTimestamp = a.timestamp ?? constants.Zero
  const bTimestamp = b.timestamp ?? constants.Zero

  return aTimestamp.gt(bTimestamp) ? -1 : 1
}

// later
something.sort(sortByTimestampDescending)